Set cmake_minimum_required(VERSION 3.22) #175
Conversation
|
Concept ~0 assuming #163 is merged first. This PR is doing two different things (see #163 (comment))
I think the first change is good. The second change seems a like it introduces misleading documentation and an inappropriate error message, but it is not very damaging and seems ok if we want to be paranoid about old versions of cmake doing bad things. I would like to see #163 merged first because it is only doing the first thing, not the second thing and I do think it is good to keep these things separate for clarity. |
correct. Thanks for making it explicit. I like both things and I think it is the most simple and most practical way forward for now. |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
It is unclear if an earlier version is supported, because no one (neither CI nor developers) are testing an earlier version. See also #164.
Also, it is unclear why effort should be made to try to support earlier versions than Bitcoin Core (https://github.com/bitcoin/bitcoin/blob/e486597f9a57903600656fb5106858941885852f/CMakeLists.txt#L10), because libmultiprocess is currently only used there.
Once there is a need or use-case to derive from Bitcoin Core, the policy could be changed then.
Bumping the minimum could also unlock simpler cmake code, see #163 (comment)